[PATCH] WikiCalendarMacros.get_macro_description() doesn't work on Trac 0.12.x

[Jun Omae]

Getting the description for [[WikiCalendar*]], the following is rendered instead.

Error: Can't get description for macro WikiCalendar

global name 'gettext' is not defined

wikicalendar/api.py

@@ -14 +14 @@
 # by keeping Babel optional here.
 try:
     from trac.util.translation import domain_functions
-    add_domain, _, tag_ = \
-        domain_functions('wikicalendar', ('add_domain', '_', 'tag_'))
+    add_domain, _, gettext, tag_ = \
+        domain_functions('wikicalendar',
+                         ('add_domain', '_', 'gettext', 'tag_'))
 except ImportError:
     from genshi.builder import tag as tag_
     from trac.util.translation import gettext

[Steffen Hoffmann]

(In [12846]) WikiCalendarMacro: Extract missing gettext from domain_functions, refs #10991.

As Jun Omae noticed instantly, I forgot to import the gettext call that I introduced for 0.12 compatibility in [12843] last night. Thank you for your review and proposed patch.

[Steffen Hoffmann]

(In [12991]) WikiCalendarMacro: Releasing current, tested macro package as final product, closes #7639, #8175, #9718, #10991, #10992 and #10993.

Special thanks to Jun Omae for pushing development by testing and providing valuable hints in our discussion about utilizing Babel for better localization and for making macro execution thread-safe as well.