#10384 closed defect (fixed)
Properly cast `authenticated` field for subscription_attribute table
Reported by: | Eygene Ryabinkin | Owned by: | Steffen Hoffmann |
---|---|---|---|
Priority: | normal | Component: | AnnouncerPlugin |
Severity: | normal | Keywords: | |
Cc: | Steffen Hoffmann, scottso@…, Bas van der Vlies | Trac Release: | 0.12 |
Description (last modified by )
authenticated
is an integer in SQL schema, so it should be properly cast: for example, PostgreSQL is picky about this.
Attachments (1)
Change History (13)
Changed 12 years ago by
Attachment: | patch-announcer-model-authenticated-typecasts added |
---|
comment:1 Changed 12 years ago by
Cc: | Steffen Hoffmann added; anonymous removed |
---|
comment:2 Changed 12 years ago by
Description: | modified (diff) |
---|---|
Summary: | Properly cast "authenticated" field for subscription_attribute table → Properly cast `authenticated` field for subscription_attribute table |
comment:3 Changed 12 years ago by
Cc: | scottso@… Bas van der Vlies added |
---|
comment:7 Changed 12 years ago by
#8065 closed as a duplicate, and it has a patch which we may want to review.
comment:8 Changed 12 years ago by
(In [12302]) TracAnnouncer: Part 7 of 7 - Finally: Go from present to future, refs #5774, #7975, #8065, #9742 and #10384.
Now we've bridged the gap and provide an upgrade path for each historic schema
revision of this plugin, while data migration is incomplete yet, especially
regarding subscription attributes stored in session_attribute
(before v3).
Due to component name changes the conversion will be rather complicated, and
therefore corresponding research and development is postponed to a future date
and will largely depend on explicite demand as well.
comment:9 Changed 12 years ago by
(In [12303]) TracAnnouncer: Convert type to match db table definitions, refs #7975, #8065 and #10384.
These changes are based on work by olistudent, Stephen Anderson and rea. I made sure, that we respect PEP8 as well, at least as far as Trac core does.
Thanks to all of you for testing, reports and suggestions towards a portable fix, and - ultimately - patience to get it finally resolved.
comment:10 Changed 10 years ago by
Owner: | Robert Corsaro deleted |
---|
comment:11 Changed 8 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:12 Changed 8 years ago by
Owner: | set to Steffen Hoffmann |
---|
This patch looks correct to me.
authenticated
is anINT
in the database schema (t:TracDev/DatabaseSchema) and is abool
in the Session class, where it is cast toint
before writing to the database.