Cannot update a ticket while changing child ticket to parent ticket (and vice versa) with a 'comment'.

[anonymous]

While changing child ticket to parent ticket in a ticket ,If we give some comment and submit both then there is no update in ticket and There is Integrity Error

IntegrityError: columns ticket, time, field are not unique

File "C:/SDWorkbenchServer/python/lib/site-packages/trac-0.12.2-py2.7.egg/trac/web/main.py", line 511, in _dispatch_request
  dispatcher.dispatch(req)
File "C:/SDWorkbenchServer/python/lib/site-packages/trac-0.12.2-py2.7.egg/trac/web/main.py", line 237, in dispatch
  resp = chosen_handler.process_request(req)
File "C:/SDWorkbenchServer/python/lib/site-packages/trac-0.12.2-py2.7.egg/trac/ticket/web_ui.py", line 169, in process_request
  return self._process_ticket_request(req)
File "C:/SDWorkbenchServer/python/lib/site-packages/trac-0.12.2-py2.7.egg/trac/ticket/web_ui.py", line 541, in _process_ticket_request
  self._do_save(req, ticket, action)
File "C:/SDWorkbenchServer/python/lib/site-packages/trac-0.12.2-py2.7.egg/trac/ticket/web_ui.py", line 1238, in _do_save
  cnum=internal_cnum):
File "C:/SDWorkbenchServer/python/lib/site-packages/trac-0.12.2-py2.7.egg/trac/ticket/model.py", line 360, in save_changes
  listener.ticket_changed(self, comment, author, old_values)
File "C:/SDWorkbenchServer/python/lib/site-packages/tracmastertickets-3.0.2-py2.7.egg/mastertickets/api.py", line 120, in ticket_changed
  links.save(author, comment, tkt.time_changed, db)
File "C:/SDWorkbenchServer/python/lib/site-packages/tracmastertickets-3.0.2-py2.7.egg/mastertickets/model.py", line 83, in save
  (n, when_ts, author, 'comment', '', '(In #%s) %s'%(self.tkt.id, comment)))
File "C:/SDWorkbenchServer/python/lib/site-packages/trac-0.12.2-py2.7.egg/trac/db/util.py", line 65, in execute
  return self.cursor.execute(sql_escape_percent(sql), args)
File "C:/SDWorkbenchServer/python/lib/site-packages/trac-0.12.2-py2.7.egg/trac/db/sqlite_backend.py", line 78, in execute
  result = PyFormatCursor.execute(self, *args)
File "C:/SDWorkbenchServer/python/lib/site-packages/trac-0.12.2-py2.7.egg/trac/db/sqlite_backend.py", line 56, in execute
  args or [])
File "C:/SDWorkbenchServer/python/lib/site-packages/trac-0.12.2-py2.7.egg/trac/db/sqlite_backend.py", line 48, in _rollback_on_error
  return function(self, *args, **kwargs)

[anonymous]

When we updating parent/child ticket with comment , the logic (for loop) was iterating 2 times to modify "parent field" and "child field" each in model.py . Each time while modifying if comment is given in field , it was updating that also. In first iteration the comment field was modified so in second iteration while changing it was throwing error. By making comment field to change only in one time, we can prevent the error. check out modified script(model.py) as attachment.

[anonymous]

Modified file

[Ryan J Ollos]

Unified diff is the preferred format for a patch. If I diff against the latest revision of model.py, I get:

model.py

@@ -1 @@
-import copy
+# Created by Noah Kantrowitz on 2007-07-04.
+# Copyright (c) 2007 Noah Kantrowitz. All rights reserved.
+import copy
 from datetime import datetime
 
 from trac.ticket.model import Ticket
@@ -7 +9 @@
 
 class TicketLinks(object):
     """A model for the ticket links used MasterTickets."""
-    
+
     def __init__(self, env, tkt, db=None):
         self.env = env
         if not isinstance(tkt, Ticket):
@@ -46 +48 @@
             (new_blocked_by, self._old_blocked_by, 'blocking', ('dest', 'source')),
         ]
         
-        comment_enable_flag = True 
         for new_ids, old_ids, field, sourcedest in to_check:
             for n in new_ids | old_ids:
                 update_field = None
@@ -70 +71 @@
                     cursor.execute('INSERT INTO ticket_change (ticket, time, author, field, oldvalue, newvalue) VALUES (%s, %s, %s, %s, %s, %s)', 
                                    (n, when_ts, author, field, old_value, new_value))
                                    
-                    if comment and comment_enable_flag == True: # comment field shound modify once even for multiple changes
+                    if comment:
                         cursor.execute('INSERT INTO ticket_change (ticket, time, author, field, oldvalue, newvalue) VALUES (%s, %s, %s, %s, %s, %s)', 
                                        (n, when_ts, author, 'comment', '', '(In #%s) %s'%(self.tkt.id, comment)))
-                        comment_enable_flag = False 
+                                   
                            
                     cursor.execute('UPDATE ticket_custom SET value=%s WHERE ticket=%s AND name=%s',
                                    (new_value, n, field))
@@ -84 +85 @@
                     if not cursor.rowcount:
                         cursor.execute('INSERT INTO ticket_custom (ticket, name, value) VALUES (%s, %s, %s)',
                                        (n, field, new_value))
-       
+        
+        # cursor.execute('DELETE FROM mastertickets WHERE source=%s OR dest=%s', (self.tkt.id, self.tkt.id))
+        # data = []
+        # for tkt in self.blocking:
+        #     if isinstance(tkt, Ticket):
+        #         tkt = tkt.id
+        #     data.append((self.tkt.id, tkt))
+        # for tkt in self.blocked_by:
+        #     if isisntance(tkt, Ticket):
+        #         tkt = tkt.id
+        #     data.append((tkt, self.tkt.id))
+        # 
+        # cursor.executemany('INSERT INTO mastertickets (source, dest) VALUES (%s, %s)', data)
         
         if handle_commit:
             db.commit()
@@ -105 +118 @@
                (self.tkt.id, l(getattr(self, 'blocking', [])), l(getattr(self, 'blocked_by', [])))
 
     @staticmethod
-    def walk_tickets(env, tkt_ids):
+    def walk_tickets(env, tkt_ids, full=False):
         """Return an iterable of all links reachable directly above or below those ones."""
-        def visit(tkt, memo, next_fn):
+        def visit(tkt, memo, next_fn, full=False):
             if tkt in memo:
                 return False
             
@@ -120 +133 @@
         memo1 = {}
         memo2 = {}
         for id in tkt_ids:
-            visit(id, memo1, lambda links: links.blocking)
-            visit(id, memo2, lambda links: links.blocked_by)
+            if full:
+                visit(id, memo1, lambda links: links.blocking|links.blocked_by)
+            else:
+                visit(id, memo1, lambda links: links.blocking)
+                visit(id, memo2, lambda links: links.blocked_by)
         memo1.update(memo2)
         return memo1.itervalues()

[Ryan J Ollos]

It looks like my diff in comment:3 is backwards. Anyway, Duplicate of #10194.