Modify ↓

Opened 13 years ago

Closed 8 years ago

#10083 closed enhancement (fixed)

Notifications from attachments do not include user name

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Component: AnnouncerPlugin
Severity: normal Keywords: HTML formatting
Cc: Steffen Hoffmann Trac Release: 0.11

Description

The notification emails for user comment show the user name:

The notification emails for attachments do not:

Attachments (4)

Comments.png​ (8.1 KB) - added by Ryan J Ollos 13 years ago.
Attachments.png​ (6.9 KB) - added by Ryan J Ollos 13 years ago.
HtmlAttachmentNotification.png​ (5.5 KB) - added by anonymous 12 years ago.
th10083-r12265-1.patch​ (1.6 KB) - added by Ryan J Ollos 12 years ago.
Patch against r12265 of the AnnouncerPlugin trunk.

Download all attachments as: .zip

Change History (12)

Changed 13 years ago by Ryan J Ollos

Attachment: Comments.png​ added

Changed 13 years ago by Ryan J Ollos

Attachment: Attachments.png​ added

comment:1 Changed 12 years ago by Ryan J Ollos

Owner: changed from Robert Corsaro to Ryan J Ollos
Status: new → assigned

Changed 12 years ago by anonymous

Attachment: HtmlAttachmentNotification.png​ added

comment:2 Changed 12 years ago by Ryan J Ollos

Here is an example of a plain text email: 

Changes (by anonymous):
Attachment:
 * File 'Packages' added

The attached patch adds a linebreak: 

Changes (by anonymous):

Attachment:
 * File 'Packages' added

and modifies the HTML template so that it matches the plain text template:

hasienda: Let me know if the change looks okay to you and if so I'll commit it. See also #10584.

Changed 12 years ago by Ryan J Ollos

Attachment: th10083-r12265-1.patch​ added

Patch against r12265 of the AnnouncerPlugin trunk.

comment:3 in reply to:  2 Changed 12 years ago by Steffen Hoffmann

Keywords: HTML formatting added

Replying to rjollos:
...

hasienda: Let me know if the change looks okay to you and if so I'll commit it. See also #10584.

Looks good to me, please commit.

comment:4 Changed 12 years ago by Ryan J Ollos

(In [12266]) Refs #10083: Fixed - HTML notification for attachments do not include the author name.

comment:5 Changed 12 years ago by Ryan J Ollos

Status: assigned → new

comment:6 Changed 8 years ago by Ryan J Ollos

Owner: Ryan J Ollos deleted

comment:7 Changed 8 years ago by Ryan J Ollos

Owner: set to Ryan J Ollos
Status: new → accepted

comment:8 Changed 8 years ago by Ryan J Ollos

Resolution: → fixed
Status: accepted → closed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.